Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common fields to RetryDetails #126

Merged
merged 3 commits into from
Nov 28, 2019
Merged

Add common fields to RetryDetails #126

merged 3 commits into from
Nov 28, 2019

Conversation

LukaJCB
Copy link
Collaborator

@LukaJCB LukaJCB commented Nov 26, 2019

Should fix #124

@LukaJCB LukaJCB requested a review from cb372 November 26, 2019 14:37
@LukaJCB
Copy link
Collaborator Author

LukaJCB commented Nov 26, 2019

We could also add a boolean field givingUp for convenience. WDYT?

@cb372 cb372 merged commit aeb7765 into master Nov 28, 2019
@cb372 cb372 deleted the retry-details branch November 28, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Place common fields of RetryDetails subtypes on RetryDetails itself.
2 participants