Do the reserved check on the receiving end of the event #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The receiving end on should be validating if they are allowed to emit the event. In the previous senario it would be possible that the server emitted an `reconnect` event and it would trigger on the client as it's not blocked on the server. It would also be impossible to emit an `reconnect` event on the server as that event is client is blocked by the client. This simple trivial change would fix both cases without requiring a list of ALL events that are used in Primus.
cayasso
added a commit
that referenced
this pull request
Feb 3, 2014
Do the reserved check on the receiving end of the event
|
Great idea, thanks @3rd-Eden!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The receiving end on should be validating if they are allowed to emit the event. In the previous senario it would be possible that the server emitted an
reconnectevent and it would trigger on the client as it's not blocked on the server. It would also be impossible to emit anreconnectevent on the server as that event is client is blocked by the client.This simple trivial change would fix both cases without requiring a list of ALL events that are used in Primus.