Skip to content

Major version bump #20

Closed
Closed
@lpinca

Description

@lpinca

primus-emitter@2.1.x is compatible with primus@2.x.x as well as with the primus@1.x.x series.

This is not completely true. primus-emitter@2.1.x will only work on primus@2.x.x.
We don't have a reserved method on primus@1.x.x so this line emitter.js#L111 will most likely cause the crash of the server.
We also removed the reserved events from primus-emitter@2.1.x and therefore we can't block these events on primus@1.x.x.

primus-emitter@2.0.x works with primus@2.x.x but we have some missing reserved events in the 2.0.x series. The readyStateChange event for example, so it should not be used with primus@2.x.x.

I think that a major version bump makes sense here.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions