Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: DO-3658: Fix Table non-unique index values, fix sorting by unnamed index #363

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

Roman-Kornev
Copy link
Contributor

Motivation and Context

  • Fixed a crash in Table pagination where rows containing non-unique index values would cause a slicing error, as rows were paginated by DataFrame index instead of iloc row ordering.
  • Fixed an issue in Table where sorting by an unnamed index would not work, as the default __index__ unnamed index column does not exist in the original DataFrame.

Implementation Description

Any new dependencies Introduced

How Has This Been Tested?

PR Checklist:

  • I have implemented all requirements? (see JIRA, project documentation).
  • I am not affecting someone else's work, If I am, they are included as a reviewer.
  • I have added relevant tests (unit, integration or regression).
  • I have added comments to all the bits that are hard to follow.
  • I have added/updated Documentation.
  • I have updated the appropriate changelog with a line for my changes.

Screenshots (if appropriate):

Copy link
Contributor

@patricia-causalens patricia-causalens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM!

Copy link
Collaborator

@krzysztof-causalens krzysztof-causalens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Roman-Kornev Roman-Kornev merged commit 26fe0ca into master Aug 23, 2024
6 checks passed
@Roman-Kornev Roman-Kornev deleted the table-index-fix branch August 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants