-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: DO-3453 make chat component more flexible and UI updates #344
Improvement: DO-3453 make chat component more flexible and UI updates #344
Conversation
/** Whether the chat is in a popup and should be styled as such */ | ||
isPopup?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be more composable instead if you exposed effectively this component without the wrapper (so 'ChatBody', ReplyWrapper + the logic, intended to be rendered directly) as a 'Chat' component and then a 'ChatPopup' which would wrap the first component? Or are the popup visuals partially in dara-components?
Feels like it could be a nicer pattern than having to do conditional styling, this way the place where we use it can choose to use its own wrapper if need be rather than be stuck with the two provided options.
If it's urgent I'm fine with the current approach but I think it could maybe be improved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is fair. Will make a separate ticket to look into improving this, but given tight timings will merge this one for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Motivation and Context
Update chat component in order to make it more flexible and with latest design
Implementation Description
Textarea
component so that as you type the are grows for chat component usageAny new dependencies Introduced
None
How Has This Been Tested?
Locally on storybook and a test app
PR Checklist:
Screenshots (if appropriate):