feat: add new way to set theme #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @jaeheonji. Did you test the themes out to make sure they work? If so I'd happily merge. Closes #1. |
|
I tested it like this: Latte frappe macchiato mocha In the case of latte, it is a bright color, so I updated colors. (I referenced the wezterm color layout) |
|
LGTM Awesome. |
|
The light theme looks good. I probably need to switch to it at some point! Thanks for getting this merged! |
|
@jaeheonji Feel free to add yourself to the "Thanks to" section in the readme file if you want to! Thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First of all, thank you for creating a catppuccin theme for zellij.
A new version of zellij was released a few days ago. This version adds very cool features for setting themes.
themesdirectory zellij-org/zellij#1577Actually, I am making this PR to introduce this wonderful news.
So I made 4 themes as a test, but I'm not sure if this fits the rules of the catppuccin community.
If you plan to update yourself, I hope this PR is helpful.