Skip to content

Conversation

@GowsiSM
Copy link

@GowsiSM GowsiSM commented Dec 9, 2025

Added missing IME and composition colors to fix font ghosting in pre-edit mode:

  • editor.imeBackground
  • editor.imeForeground
  • editor.imeBorder
  • editor.compositionBackground
  • editor.compositionForeground
  • editor.compositionBorder
  • editor.placeholder.foreground

This addresses issue #434.

@backwardspy
Copy link
Member

hi, thanks for contributing! i haven't taken an in-depth look at this yet, but i notice the diff has a lot of extra noise unrelated to the IME highlights. i'm happy to keep the root dir change in packages/catppuccin-vscode/tsup.config.js, but otherwise i'd appreciate it if you could revert the unrelated changes like deleting comments and changing the signature of getUiColors.

@GowsiSM
Copy link
Author

GowsiSM commented Dec 14, 2025

Hi @backwardspy, thanks for pointing that out!

I’ve updated the existing PR to revert the unrelated changes and kept only the IME and composition color additions. Comments and the getUiColors signature are now unchanged, and the diff should be limited to the intended scope.

Please let me know if anything else needs adjustment, happy to refine it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants