Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tree-wide): remove non-catwalk images #610

Merged
merged 11 commits into from
Mar 4, 2024
Merged

chore(tree-wide): remove non-catwalk images #610

merged 11 commits into from
Mar 4, 2024

Conversation

uncenter
Copy link
Member

@uncenter uncenter commented Mar 4, 2024

As discussed in Discord, hopefully will fix our Git LFS bandwidth issue.

@github-actions github-actions bot added advent-of-code Advent Of Code anilist AniList, AniChart arch-wiki Arch Wiki boringproxy boringproxy brave-search Brave Search bsky Bluesky Social bstats bStats canvas-lms Canvas LMS chatgpt ChatGPT chatreplay ChatReplay chess.com Chess.com cinny Cinny codeberg Codeberg crowdin Crowdin deepl DeepL duckduckgo DuckDuckGo ecosia Ecosia elk Elk formative Formative github GitHub gmail Gmail google Google google-photos Google Photos graphite Graphite hackage Hackage labels Mar 4, 2024
Copy link
Member

@justTOBBI justTOBBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@sgoudham
Copy link
Contributor

sgoudham commented Mar 4, 2024

To add extra context to this PR.

We're starting to run out of git-lfs bandwidth from the assets on this repository:
image

I briefly looked into the "data packs" that GitHub offer to increase this limit, and it looks like you can only increase storage and bandwidth at the same time. One data pack is 5$ per month and would bump us to 50GB storage and 50GB bandwidth.

While we do have the money to fund this, I'm not comfortable with spending OC money on this and feel like it would be a waste of money from the lovely people that have donated to us (compared to purchasing domains, mail server, etc)

@isabelroses raised a good point that most people, probably, dont bother viewing the individual image previews so removing them here makes the most sense right now. I suppose we'll have this discussion again if/when the bandwidth runs out from just the catwalk images.

@uncenter
Copy link
Member Author

uncenter commented Mar 4, 2024

I suppose we'll have this discussion again if/when the bandwidth runs out from just the catwalk images.

I think we'd have to get something like 3 times as much traffic as we do now to pass the 1GB bandwidth threshold with only the preview.webp images, and since (unfortunately) I'm guessing our traffic won't increase to that level any time soon... we probably won't be having that conversation again soon?

@Tnixc
Copy link
Member

Tnixc commented Mar 4, 2024

Is there a reason the images must be hosted on github? There's plenty of free image hosts out there. Not sure if we discussed this before.

@uncenter
Copy link
Member Author

uncenter commented Mar 4, 2024

Is there a reason the images must be hosted on github?

Hosting in GitHub makes it easier to maintain and contribute to IMO.

There's plenty of free image hosts out there.

Any suggestions/ideas/examples of those?

@sgoudham
Copy link
Contributor

sgoudham commented Mar 4, 2024

Is there a reason the images must be hosted on github? There's plenty of free image hosts out there. Not sure if we discussed this before.

Personally, I followed the template at the beginning without necessarily thinking about the scale in which this repository might grow into. I think just having the catwalk image is fine instead of needing the 4 individual image previews for each folder in this repository (and/or needlessly investing into an image hosting service)

@Tnixc
Copy link
Member

Tnixc commented Mar 4, 2024

Yeah that makes sense

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not flatten the directories a bit by having the preview in the same dir as the readme and theme.

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the template.

@uncenter
Copy link
Member Author

uncenter commented Mar 4, 2024

Please also update the template.

What do you mean "the template"?

@uncenter
Copy link
Member Author

uncenter commented Mar 4, 2024

Why not flatten the directories a bit by having the preview in the same dir as the readme and theme.

Isn't it assets/preview.webp in catppuccin/template or similar? I guess we could? I'll leave it up to you/Hammy.

@isabelroses
Copy link
Member

isabelroses commented Mar 4, 2024

Please also update the template.

What do you mean "the template"?

Currently the template also has the old previews too. i.e. mocha.webp

@isabelroses
Copy link
Member

Why not flatten the directories a bit by having the preview in the same dir as the readme and theme.

Isn't it assets/preview.webp in catppuccin/template or similar? I guess we could? I'll leave it up to you/Hammy.

It is like that in catppuccin/template. But since we are moving away from that template here, I don't see why we can't flatten the directories out.

@sgoudham
Copy link
Contributor

sgoudham commented Mar 4, 2024

hy not flatten the directories a bit by having the preview in the same dir as the readme and theme.

I like this, since assets/preview.webp doesn't really give any further meaning than just having a preview.webp in the same directory as the other files.

The one exception iirc would be chess.com since the assets folder holds other images.

@uncenter
Copy link
Member Author

uncenter commented Mar 4, 2024

Please also update the template.

What do you mean "the template"?

Currently the template also has the old previews too. i.e. mocha.webp

Ah I didn't even realize the template had preview images... what are they even screenshots of lol??

@uncenter uncenter merged commit 1c222d8 into catppuccin:main Mar 4, 2024
4 of 6 checks passed
@uncenter uncenter deleted the chore/remove-non-catwalk branch March 4, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advent-of-code Advent Of Code anilist AniList, AniChart arch-wiki Arch Wiki boringproxy boringproxy brave-search Brave Search bsky Bluesky Social bstats bStats canvas-lms Canvas LMS chatgpt ChatGPT chatreplay ChatReplay chess.com Chess.com cinny Cinny codeberg Codeberg crowdin Crowdin deepl DeepL duckduckgo DuckDuckGo ecosia Ecosia elk Elk formative Formative github GitHub gmail Gmail google Google google-photos Google Photos graphite Graphite hackage Hackage hacker-news Hacker News holodex Holodex homepage homepage hoppscotch Hoppscotch ichi.moe ichi.moe instagram Instagram invidious Invidious invokeai InvokeAI lastfm Last.fm lemmy Lemmy libreddit Libreddit, Redlib lichess Lichess lingva Lingva linkedin LinkedIn mastodon Mastodon mdn MDN microsoft-word Microsoft Word migadu-webmail Migadu Webmail minesweeper Minesweeper Online modrinth Modrinth nextjs Next.js nitter Nitter nixos.wiki NixOS Wiki nixos-search NixOS Search npm npm openmediavault openmediavault paste.rs paste.rs perplexity Perplexity pinterest Pinterest planet-minecraft Planet Minecraft proton Proton quizlet Quizlet reddit Reddit searxng SearXNG snapchat-web Snapchat Web spotify-web Spotify Web startpage Startpage stylus Stylus substack Substack syncthing Syncthing tuta Tuta twitch Twitch twitter Twitter vercel Vercel, Next.js whatsapp-web WhatsApp Web wikipedia Wikipedia wikiwand Wikiwand youtube YouTube
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants