-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tree-wide): remove non-catwalk images #610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
To add extra context to this PR. We're starting to run out of git-lfs bandwidth from the assets on this repository: I briefly looked into the "data packs" that GitHub offer to increase this limit, and it looks like you can only increase storage and bandwidth at the same time. One data pack is 5$ per month and would bump us to 50GB storage and 50GB bandwidth. While we do have the money to fund this, I'm not comfortable with spending OC money on this and feel like it would be a waste of money from the lovely people that have donated to us (compared to purchasing domains, mail server, etc) @isabelroses raised a good point that most people, probably, dont bother viewing the individual image previews so removing them here makes the most sense right now. I suppose we'll have this discussion again if/when the bandwidth runs out from just the |
I think we'd have to get something like 3 times as much traffic as we do now to pass the 1GB bandwidth threshold with only the |
Is there a reason the images must be hosted on github? There's plenty of free image hosts out there. Not sure if we discussed this before. |
Hosting in GitHub makes it easier to maintain and contribute to IMO.
Any suggestions/ideas/examples of those? |
Personally, I followed the template at the beginning without necessarily thinking about the scale in which this repository might grow into. I think just having the catwalk image is fine instead of needing the 4 individual image previews for each folder in this repository (and/or needlessly investing into an image hosting service) |
Yeah that makes sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not flatten the directories a bit by having the preview in the same dir as the readme and theme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the template.
What do you mean "the template"? |
Isn't it assets/preview.webp in catppuccin/template or similar? I guess we could? I'll leave it up to you/Hammy. |
Currently the template also has the old previews too. i.e. mocha.webp |
It is like that in catppuccin/template. But since we are moving away from that template here, I don't see why we can't flatten the directories out. |
I like this, since The one exception iirc would be chess.com since the assets folder holds other images. |
Ah I didn't even realize the template had preview images... what are they even screenshots of lol?? |
As discussed in Discord, hopefully will fix our Git LFS bandwidth issue.