Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tree-wide): consistent metadata #557

Merged
merged 9 commits into from
Feb 25, 2024
Merged

refactor(tree-wide): consistent metadata #557

merged 9 commits into from
Feb 25, 2024

Conversation

uncenter
Copy link
Member

This PR fixes the lint warnings brought by #522 by replacing flavor with darkFlavor and lightFlavor, adding accentColor where needed, and other fixes.

@github-actions github-actions bot added advent-of-code Advent Of Code anilist AniList, AniChart arch-wiki Arch Wiki boringproxy boringproxy brave-search Brave Search bsky Bluesky Social bstats bStats canvas-lms Canvas LMS chatgpt ChatGPT chatreplay ChatReplay chess.com Chess.com cinny Cinny codeberg Codeberg deepl DeepL duckduckgo DuckDuckGo ecosia Ecosia elk Elk formative Formative github GitHub gmail Gmail google Google graphite Graphite hackage Hackage hacker-news Hacker News homepage homepage hoppscotch Hoppscotch ichi.moe ichi.moe labels Feb 25, 2024
@uncenter

This comment was marked as resolved.

Sign in to view
r58Playz
r58Playz previously approved these changes Feb 25, 2024
View reviewed changes
TheMemeSniper
TheMemeSniper previously approved these changes Feb 25, 2024
View reviewed changes
cecelot
cecelot previously approved these changes Feb 25, 2024
View reviewed changes
BlankParticle
BlankParticle previously approved these changes Feb 25, 2024
View reviewed changes
Tnixc
Tnixc previously approved these changes Feb 25, 2024
View reviewed changes
justTOBBI
justTOBBI previously approved these changes Feb 25, 2024
View reviewed changes
AnubisNekhet
AnubisNekhet previously approved these changes Feb 25, 2024
View reviewed changes
isabelroses
isabelroses previously approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code read, nothing seems to cause any alarm. 60/68 websites tested, no regressions/issues outside of ones that already exist.

jn-sena
jn-sena previously approved these changes Feb 25, 2024
View reviewed changes
uncenter
uncenter commented Feb 25, 2024
View reviewed changes
Copy link
Member Author

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I've gone through everything again and I'm pretty confident there aren't any issues with it.

@isabelroses isabelroses merged commit ded7419 into catppuccin:main Feb 25, 2024
5 of 6 checks passed
@uncenter uncenter deleted the refactor/consistent-metadta branch February 25, 2024 19:32
This was referenced Mar 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelroses isabelroses isabelroses approved these changes

@BlankParticle BlankParticle BlankParticle left review comments

@AnubisNekhet AnubisNekhet AnubisNekhet left review comments

@Tnixc Tnixc Tnixc left review comments

@cecelot cecelot cecelot left review comments

@TheMemeSniper TheMemeSniper TheMemeSniper left review comments

@justTOBBI justTOBBI justTOBBI left review comments

@jn-sena jn-sena jn-sena left review comments

@r58Playz r58Playz r58Playz left review comments

@Dandraghas Dandraghas Awaiting requested review from Dandraghas Dandraghas is a code owner

@mustafakhalaf-git mustafakhalaf-git Awaiting requested review from mustafakhalaf-git

@FrancoRav FrancoRav Awaiting requested review from FrancoRav FrancoRav is a code owner

@ryanccn ryanccn Awaiting requested review from ryanccn ryanccn is a code owner

@watatomo watatomo Awaiting requested review from watatomo watatomo is a code owner

@nekowinston nekowinston Awaiting requested review from nekowinston

@coopw1 coopw1 Awaiting requested review from coopw1 coopw1 is a code owner

@bartlibert bartlibert Awaiting requested review from bartlibert

@Sekki21956 Sekki21956 Awaiting requested review from Sekki21956 Sekki21956 is a code owner

@spaghettiosareyummy spaghettiosareyummy Awaiting requested review from spaghettiosareyummy spaghettiosareyummy is a code owner

@soya-daizu soya-daizu Awaiting requested review from soya-daizu soya-daizu is a code owner

@Nyameliaaaa Nyameliaaaa Awaiting requested review from Nyameliaaaa Nyameliaaaa is a code owner

@Gandalf-the-Blue Gandalf-the-Blue Awaiting requested review from Gandalf-the-Blue Gandalf-the-Blue is a code owner

@thismoon thismoon Awaiting requested review from thismoon thismoon is a code owner

@rubyowo rubyowo Awaiting requested review from rubyowo rubyowo is a code owner

@GenShibe GenShibe Awaiting requested review from GenShibe GenShibe is a code owner

@lucasmelin lucasmelin Awaiting requested review from lucasmelin lucasmelin is a code owner

@coldenate coldenate Awaiting requested review from coldenate

@skelebro1 skelebro1 Awaiting requested review from skelebro1

@rockquiet rockquiet Awaiting requested review from rockquiet rockquiet is a code owner

@RoootTheFox RoootTheFox Awaiting requested review from RoootTheFox RoootTheFox is a code owner

@ndsboy ndsboy Awaiting requested review from ndsboy ndsboy is a code owner

Assignees
No one assigned
Labels
advent-of-code Advent Of Code anilist AniList, AniChart arch-wiki Arch Wiki boringproxy boringproxy brave-search Brave Search bsky Bluesky Social bstats bStats canvas-lms Canvas LMS chatgpt ChatGPT chatreplay ChatReplay chess.com Chess.com cinny Cinny codeberg Codeberg deepl DeepL duckduckgo DuckDuckGo ecosia Ecosia elk Elk formative Formative github GitHub gmail Gmail google Google graphite Graphite hackage Hackage hacker-news Hacker News homepage homepage hoppscotch Hoppscotch ichi.moe ichi.moe instagram Instagram invidious Invidious invokeai InvokeAI lastfm Last.fm lemmy Lemmy libreddit Libreddit, Redlib lichess Lichess lingva Lingva linkedin LinkedIn mastodon Mastodon mdn MDN microsoft-word Microsoft Word migadu-webmail Migadu Webmail modrinth Modrinth nextjs Next.js nitter Nitter nixos.wiki NixOS Wiki nixos-search NixOS Search npm npm openmediavault openmediavault paste.rs paste.rs perplexity Perplexity pinterest Pinterest planet-minecraft Planet Minecraft proton Proton quizlet Quizlet reddit Reddit searxng SearXNG spotify-web Spotify Web startpage Startpage substack Substack syncthing Syncthing tuta Tuta twitch Twitch twitter Twitter vercel Vercel, Next.js whatsapp-web WhatsApp Web wikiwand Wikiwand youtube YouTube
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@uncenter @r58Playz @jn-sena @justTOBBI @TheMemeSniper @cecelot @isabelroses @Tnixc @AnubisNekhet @BlankParticle