Move iterable docstring from Flavor to FlavorColors#73
Merged
backwardspy merged 1 commit intocatppuccin:mainfrom Sep 4, 2024
Merged
Move iterable docstring from Flavor to FlavorColors#73backwardspy merged 1 commit intocatppuccin:mainfrom
backwardspy merged 1 commit intocatppuccin:mainfrom
Conversation
gio8tisu
changed the title
backwardspy
approved these changes
Sep 4, 2024
Member
backwardspy
left a comment
backwardspy
left a comment
There was a problem hiding this comment.
good spot! thanks so much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
Flavordocstring wrongly states that it's iterable (Can be iterated over, in which case the colors are yielded in order.). I assume this was ment to be put inFlavorColorsinstead.Simply moved the docstring part there. If you prefer, I can make
Flavoran actual iterator which iterates over its colors.BEGIN_COMMIT_OVERRIDE
docs: move iterable docstring from Flavor to FlavorColors
END_COMMIT_OVERRIDE