Some problems about highlight groups

[mao-yining]

I tried to add cattpuccin in vim/colorschemes and here is some problems and solutions about their reviews.

Format of this issue

Group                Foreground        Background        Attributes

Problem: Lack support of Toolbar

Solution:

ToolbarLine	none	none
ToolbarButton	rosewater	none	bold

Problem: Todo is not clear in diff colors

Solution: reverse it

-Todo                 base              flamingo          bold
+Todo                 flamingo          base              bold

Problem: Lack of some links

PopupNotification -> WarningMsg
LineNrAbove -> LineNr
LineNrBelow -> LineNr
CursorLineSign -> FoldColumn

Problem: Lack of Added/Changed/Removed

Added                green             none
Removed              red               none
Changed              blue              none

Problem: Suggest to make lCursor/CursorIM different from Cursor

lCursor              base              red
CursorIM             base              mauve

Problem: Suggest to make StatusLineNC/StatusLine much clearer

It is quite hard to quickly see the active window for me, but I guess this is a design choice? image

TODO: not solved

Problem: For quickfix, it is not clear what is the quickfixline what is visual:

TODO: not solved

Problem: Suggest to remove MatchParen's background color

The last } is not actually selected, but visually it looks like it is:

MatchParen needs to be distinguishable from Visual

Here it is visually selected and it has no difference with previous screenshot:

Solution:

-MatchParen           peach             surface1          bold
+MatchParen           peach             none              bold

Problem: There are some of the Pmenu* highlights missing

Solution:

PmenuMatch	peach	mantle
PmenuMatchSel	peach	surface0

If you have some advices or different views about my solutions, please point out.

[comfysage]

this project currently has vim support but that part of the codebase has not been maintained in ages.
we're currently moving to drop support for vim and leave that up to catppuccin/vim . #932

some of these issues are dependent on vim-specific features (see vim-differences):

• the Toolbar highlight groups are dependent on a toolbar feature that is not supported in neovim.
• the PopupNotification highlight group is not supported by neovim as it has not adopted vim's popup feature (fully).

the "Suggest to make StatusLineNC/StatusLine much clearer" is a design decision. finding the active window is mainly visible through the cursor. if users experience issues they can override the highlight group or simply use something like shade.nvim.

missing links:

• the LineNrAbove and LineNrBelow are by default already linked to LineNr.
• CursorLineSign is already linked to SignColumn by default. whether this is a good choice is a different discussion.

neovim's default highlight groups also use the same colors for Cursor, lCursor and CursorIM.

---

ill address the other issues in a pr. #941

[mao-yining]

Thanks for your quick reply.