feat: Add (rudimentary) support for listings package#31
Draft
atticus-sullivan wants to merge 1 commit intomainfrom
Draft
feat: Add (rudimentary) support for listings package#31atticus-sullivan wants to merge 1 commit intomainfrom
atticus-sullivan wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
Note, I intentionally did not push the updated assets and examples yet to avoid frequent changes to binary files in git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #20
I'm open for suggestions (@walshyb maybe).
Without standardization (e.g. keyword group 1 is always for keywords, group 2 always for builtins etc) from the listings package, I see no way of providing a better highlighting than this PR implements so far.
For me the one thing I want to investigate is to check how we can avoid this "note this package needs to be loaded after listings" in this case (maybe via https://www.latex-project.org/help/documentation/lthooks-doc.pdf?). I'd like to avoid these strong ordering for every new package we start supporting.
But one might also argue, we could also investigate how to avoid the strict ordering in the case of hyperref (with
\hypersetupit might/should be a quite similar case here) which would make this "feature" a more "global" one deserving its own PR.