-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert single category to multiple categories #2288
Conversation
BTW tty should be under the terminals category. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think I'm done for now, some notable changes aside adding new categories:
- Default to an empty list if the category has no ports (https://github.com/catppuccin/catppuccin/pull/2288/files#diff-0898aecfeab67c6aea11f4515580d6cbf88873a1c7f58722ceed347c56acbe3bR109)
- Do not display categories that have no ports in the README (https://github.com/catppuccin/catppuccin/pull/2288/files#diff-0898aecfeab67c6aea11f4515580d6cbf88873a1c7f58722ceed347c56acbe3bR117)
It's somewhat frustrating that technically adding/removing categories is technically 2 PRs in catppuccin/catppuccin and 2 PRs in catppuccin/userstyles if you want to release them together but we can figure out how to make that nicer later on.
Next Steps
- Merge this PR
- Update draft PR on
catppuccin/userstyles
to bring in the merged commit hash and merge - Raise a PR in
catppuccin/catppuccin
to update its userstyles commit hash to the merged one incatppuccin/userstyles
97b5361
to
428223b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that one question this looks solid to me! <3
Description
This PR adds more specific categories for ports to be listed against. I've tried to adopt an approach that is used in app stores where you have the concept of a primary and secondary category, but modified it to be a bit less strict.
The
category
string has been removed in favour of thecategories
array, and the first element of this array should be the most specific category, with the rest of the elements decreasing in priority.This is basically modeled for weighted fuzzy searching, where the first element has the greatest weight and the rest have smaller weights. For further information on this, see #2230 (comment)
Goals
Non Goals
ports.yml
with new portsRelease Process
I think the following steps are what need to be done for a "smooth" release:
catppuccin/catppuccin
catppuccin/userstyles
with categories updated and schema pointing to thecatppuccin/catppuccin
draft PR.catppuccin/catppuccin
to pull in newcatppuccin/userstyles
changes and merge.The reason why this is a pain is because the schemas in both repositories depend on each other, leading to a circular dependency of sorts. It might be worth to extract out the categories into a different file/schema file entirely to somewhat mitigate this issue going forward.
Edit: Thinking about it again, I don't think the merge needs to be as complicated as that since the commits are pinned, but I would like to release the changes as a set instead of one after the other.
Preview PR README.md
Closes #2230