Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent parsing of commented information #103

Open
mercury200Hg opened this issue Mar 5, 2024 · 1 comment
Open

Prevent parsing of commented information #103

mercury200Hg opened this issue Mar 5, 2024 · 1 comment

Comments

@mercury200Hg
Copy link

mercury200Hg commented Mar 5, 2024 •
edited
Loading

If a project has commented includes/triggers they are parsed as uncommented code.

Steps to reproduce:
Currently if a .gitlab-ci.yml for project-A contains something like:

# include:
#   - project: namespace-B/project-B
#     file: ci/example-template.yml

Then, it's also parsed as a relationship.
So a relationship from project-A to project-B of type INCLUDE is created which shouldn't happen.

This might need to be excluded.
catouc added a commit that referenced this issue Mar 19, 2024
@catouc
Add new tests for commented out parts in yml files
7904612 
Trying to reproduce #103.
Did not parse any commented code so will need more detailed testing to
see whether it happens further up the stack? But the crawler is just
building on these parsed slices and never gooes into the actual yaml
bytes.
@catouc
Copy link
Owner

catouc commented Mar 19, 2024

Hmm can't reproduce it with the test suite like in 7904612.

Is there any more detail on the bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mercury200Hg @catouc