Skip to content

Commit

Permalink
Merge pull request #2 from catherineisonline/refactor
Browse files Browse the repository at this point in the history
refactor
  • Loading branch information
catherineisonline authored Aug 1, 2024
2 parents 49eedb8 + bc47469 commit ae3fe24
Show file tree
Hide file tree
Showing 45 changed files with 23 additions and 29 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.DS_Store
node_modules
# dist

/dist

# local env files
.env.local
Expand Down
1 change: 0 additions & 1 deletion dist/css/app.324019b0.css

This file was deleted.

Binary file removed dist/favicon.png
Binary file not shown.
Binary file not shown.
Binary file removed dist/img/Base-Apparel-coming-soon-page.89ad7976.jpeg
Binary file not shown.
Binary file removed dist/img/FAQ-accordion-card.8248dbbe.jpeg
Binary file not shown.
Binary file removed dist/img/IP-address-tracker-challenge.f62fd571.jpeg
Binary file not shown.
Binary file not shown.
Binary file removed dist/img/NFT-preview-card-component.4d481a09.jpeg
Binary file not shown.
Binary file removed dist/img/QR-code-component.ff2455af.jpeg
Binary file not shown.
Binary file not shown.
Binary file removed dist/img/advice-generator-app.640918ae.jpeg
Binary file not shown.
Binary file removed dist/img/article-preview-component.7eb699ab.jpeg
Binary file not shown.
Binary file removed dist/img/calculator-app.5562e102.webp
Binary file not shown.
Binary file removed dist/img/crowdfunding-product-page.6be4eb8d.webp
Binary file not shown.
Binary file removed dist/img/four-card-feature-section.27887e1c.jpeg
Binary file not shown.
Binary file removed dist/img/fylo-dark-theme-landing-page.b61e6bda.jpeg
Binary file not shown.
Binary file removed dist/img/fylo-data-storage-component.37f0b885.jpeg
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed dist/img/interactive-rating-component.5c1e6efc.webp
Binary file not shown.
Binary file not shown.
Binary file removed dist/img/nav-icon.aad3d167.jpeg
Binary file not shown.
Binary file removed dist/img/news-homepage.e5b76983.webp
Binary file not shown.
Binary file removed dist/img/order-summary-component.9d1e7261.jpeg
Binary file not shown.
Binary file removed dist/img/ping-coming-soon.86691dc1.jpeg
Binary file not shown.
Binary file removed dist/img/pricing-component-with-toggle.1bd22bc8.jpeg
Binary file not shown.
Binary file not shown.
Binary file removed dist/img/profile-card-component.efbbcbc9.jpeg
Binary file not shown.
Binary file not shown.
Binary file removed dist/img/single-price-grid-component.41834b3d.jpeg
Binary file not shown.
Binary file removed dist/img/social-proof-section.bd8fd8ec.jpeg
Binary file not shown.
Binary file removed dist/img/stats-preview-card-component.cbe846ea.jpeg
Binary file not shown.
Binary file removed dist/img/sunnyside-agency-landing-page.01b94239.jpeg
Binary file not shown.
Binary file removed dist/img/testimonials-grid-section.41b1aa62.jpeg
Diff not rendered.
1 change: 0 additions & 1 deletion dist/index.html

This file was deleted.

2 changes: 0 additions & 2 deletions dist/js/app.7baa8680.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/js/app.7baa8680.js.map

This file was deleted.

8 changes: 0 additions & 8 deletions dist/js/chunk-vendors.caf87120.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/js/chunk-vendors.caf87120.js.map

This file was deleted.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"scripts": {
"serve": "export NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service serve",
"serve": "vue-cli-service serve",
"build": "vue-cli-service build",
"lint": "vue-cli-service lint"
},
Expand Down Expand Up @@ -46,4 +46,4 @@
"last 2 versions",
"not dead"
]
}
}
15 changes: 13 additions & 2 deletions public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,25 @@
<meta charset="utf-8">
<meta name="description" content="Frontend Mentor Challenge Solutions">
<meta name="keywords" content="Frontend Mentor Challenge Solutions, Frontend Mentor">
<!-- Open Graph Meta Tags -->
<meta property="og:title" content="Frontend Mentor Challenge Solutions" />
<meta property="og:description" content="Frontend Mentor Challenge Solutions" />
<meta property="og:image"
content="https://github.com/catherineisonline/frontend-mentor-challenge-solutions/raw/main/src/assets/images/Base-Apparel-coming-soon-page.jpeg?raw=true" />
<meta property="og:url" content="https://catherineisonline.github.io/frontend-mentor-challenge-solutions/" />
<meta property="og:type" content="website" />
<!-- Twitter Card Meta Tags -->
<meta name="twitter:card" content="Frontend Mentor Challenge Solutions" />
<meta name="twitter:title" content="Frontend Mentor Challenge Solutions" />
<meta name="twitter:description" content="Frontend Mentor Challenge Solutions" />
<meta name="twitter:image"
content="https://github.com/catherineisonline/frontend-mentor-challenge-solutions/raw/main/src/assets/images/Base-Apparel-coming-soon-page.jpeg?raw=true" />
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width,initial-scale=1.0">
<link rel="icon" type="image/png" sizes="32x32" href="<%= BASE_URL %>favicon.png">

<title>Frontend Mentor Challenge Solutions</title>
</head>


<body>
<div id="app"></div>
</body>
Expand Down
16 changes: 7 additions & 9 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<main>
<header v-for="headerDetail in headerDetails" v-bind:key="headerDetail.id">
<section class="header-info">
<img :src="headerDetail.headerIcon" alt="icon" />
<img :src="headerDetail.headerIcon" alt="Frontend Mentor" />
<a :href="headerDetail.projectUrl">
<h1><span>Frontend</span> Mentor Challenge Solutions</h1>
</a>
Expand All @@ -11,18 +11,16 @@
<img
class="nav-icon"
:src="headerDetail.navIcon"
alt=""
alt="Open navigation menu"
@click="click"
/>

<ul class="main-menu">
<li>
<i class="fas fa-home"></i
><a :href="headerDetail.projectUrl" @click="removeMenu">Home</a>
<i class="fas fa-home"></i><a :href="headerDetail.projectUrl" @click="removeMenu">Home</a>
</li>
<li>
<i class="fas fa-project-diagram"></i
><a
<i class="fas fa-project-diagram"></i><a
:href="headerDetail.frontendMentorUrl"
@click="removeMenu"
target="_blank"
Expand Down Expand Up @@ -64,7 +62,7 @@
<img
class="project-image"
v-bind:src="solution.projectPreview"
alt="project preview"
alt={{ solution.projectName }}
/>
</section>
<!-- Project Info -->
Expand Down Expand Up @@ -126,7 +124,7 @@ export default {
{
headerIcon: require("@/assets/images/favicon.png"),
navIcon: require("@/assets/images/nav-icon.jpeg"),
projectUrl: "https://frontend-mentor-challenge-solutions.vercel.app/",
projectUrl: "https://catherineisonline.github.io/frontend-mentor-challenge-solutions/",
frontendMentorUrl:
"https://www.frontendmentor.io/profile/catherineisonline",
gitHubUrl:
Expand Down Expand Up @@ -482,7 +480,7 @@ export default {
"If you're wanting to test your JavaScript skills this is the challenge for you. Use whichever JS framework you prefer and pull data from the REST Countries API.",
projectStack: ["HTML", "CSS", "JS", "API"],
projectPreview: require("@/assets/images/rest-countries-api-with-color-theme-switcher.jpeg"),
liveLink: "https://catherineisonline.github.io/rest-countries/",
liveLink: "https://restful-countries.vercel.app/",
projectLink:
"https://www.frontendmentor.io/solutions/rest-countries-api-with-color-theme-switcher-SySqXmn49",
Expand Down
1 change: 0 additions & 1 deletion src/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import Vue from "vue";
import App from "./App.vue";
import "./assets/styles.sass";

// Vue.config.productionTip = false;

new Vue({
render: (h) => h(App),
Expand Down

0 comments on commit ae3fe24

Please sign in to comment.