Reduce code duplication for sender/authority recovery in monad_ethblocks runloop #1933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the sender and authority recovery logic to reduce code duplication by extracting the recovery process into a reusable function. The changes improve code maintainability by eliminating three nearly identical blocks of recovery code.
- Introduces a new
RecoveredSendersAndAuthoritiesstruct to encapsulate recovery results - Creates a reusable
recover_senders_and_authoritiesfunction that consolidates duplicated recovery logic - Replaces separate
parent_senders_and_authoritiesandgrandparent_senders_and_authoritiesvariables with a circular buffer array indexed by block number modulo 3
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eclark0426
force-pushed
the
ellis/ethloop-parents-refactor
branch
2 times, most recently
from
e6b43f5 to
affe07d
Compare
jhunsaker
force-pushed
the
ellis/ethloop-parents-refactor
branch
from
affe07d to
69c863c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.