Skip to content

Conversation

@mkolosick
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings November 19, 2025 22:08
Copilot finished reviewing on behalf of mkolosick November 19, 2025 22:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR expands clang-tidy checks to the category/mpt directory, adding it to the linting script and addressing various issues flagged by the linter. The changes include:

  • Adding category/mpt to the clang-tidy check script
  • Fixing potential undefined behavior with bit shifting on negative values
  • Adding NOLINT suppressions for known analyzer bugs and false positives
  • Improving const correctness throughout the codebase
  • Cleaning up includes and variable declarations

Reviewed Changes

Copilot reviewed 54 out of 54 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scripts/check-clang-tidy.sh Added category/mpt to the list of directories checked by clang-tidy
category/mpt/util.hpp Fixed potential undefined behavior in bit shift operation using std::max to prevent negative shift
category/mpt/upward_tnode.hpp Added NOLINT suppressions for known clang-analyzer bug with uninitialized object detection
category/mpt/update_aux.cpp Added const qualifiers, NOLINT suppressions, and cleaned up includes
category/mpt/trie.hpp Removed noexcept specifiers from virtual functions and improved const correctness
category/mpt/trie.cpp Added const qualifiers and NOLINT suppressions for false positives
category/mpt/test/*.cpp Applied const correctness improvements and added explicit constructors
category/mpt/request.hpp Changed operator[] to return non-const reference and added reinitializes attribute
category/mpt/node.cpp Fixed pointer cast and removed unused includes
Other files Various const correctness improvements, include cleanups, and NOLINT suppressions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mkolosick mkolosick force-pushed the mkolosick/clang-tidy-mpt branch 2 times, most recently from aaa9212 to 8d0dcbf Compare November 20, 2025 14:55
@mkolosick mkolosick force-pushed the mkolosick/clang-tidy-mpt branch from 8d0dcbf to 3eebc7d Compare November 20, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants