switch block_reward_test tests to TraitsTest #1831
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the block_reward_test.cpp file to use a parameterized test approach via TraitsTest instead of manually testing each Ethereum hard fork separately. The change consolidates multiple test blocks into a single test that uses compile-time conditional logic to verify behavior across different EVM revisions.
Key Changes:
- Converted from individual test cases per hard fork to a single
TYPED_TESTthat validates all EVM revisions - Replaced multiple code blocks testing Frontier, Byzantium, Constantinople/Petersburg, and Paris with conditional
if constexprstatements - Standardized variable naming across test scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
goodlyrottenapple
force-pushed
the
sam/traits_test_block_reward_test
branch
from
98d36a1 to
14014c5
Compare
zander-xyz
approved these changes
Oct 28, 2025
zander-xyz
force-pushed
the
sam/traits_test_block_reward_test
branch
from
14014c5 to
0c2ec86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.