Skip to content

Conversation

@Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Oct 27, 2025

No description provided.

@Baltoli Baltoli force-pushed the bruce/monad-six-pricing branch 7 times, most recently from 50380db to baaf536 Compare October 27, 2025 19:56
@Baltoli Baltoli marked this pull request as ready for review October 27, 2025 20:14
@Baltoli Baltoli requested a review from andreaslyn as a code owner October 27, 2025 20:14
@Baltoli Baltoli requested review from Copilot, jhunsaker and msetrin and removed request for andreaslyn October 27, 2025 20:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Monad virtual machine to introduce a new revision MONAD_SIX and shifts pricing changes that were previously assigned to MONAD_NEXT to this new revision. The main purpose is to formalize and version control pricing model updates.

Key Changes:

  • Introduces MONAD_SIX as revision 6 and renumbers MONAD_NEXT to revision 7
  • Moves pricing version 1 activation from MONAD_NEXT to MONAD_SIX
  • Simplifies gas refund logic by removing MONAD_NEXT-specific conditional branches

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
category/vm/evm/monad/revision.h Adds MONAD_SIX enum value and renumbers MONAD_NEXT
category/vm/evm/traits.hpp Updates pricing version activation and removes obsolete trait methods
category/vm/evm/opcodes.hpp Adds opcode table for MONAD_SIX and simplifies MONAD_NEXT table
category/vm/runtime/storage_costs.hpp Updates storage cost tables to inherit from base traits
category/vm/evm/explicit_traits.hpp Adds template instantiations for MONAD_SIX
category/execution/ethereum/execute_transaction.cpp Simplifies gas refund logic by removing conditional branching
category/execution/monad/monad_transaction_gas.cpp Removes MONAD_NEXT-specific gas refund computation
category/execution/ethereum/transaction_gas.cpp Removes unused refund_gas_price function
category/execution/ethereum/transaction_gas.hpp Removes refund_gas_price function declaration
category/execution/monad/monad_transaction_gas.hpp Removes refund_gas_price function declaration
test/vm/unit/evm_tests.cpp Removes obsolete block gas overflow test
category/rpc/eth_call_test.cpp Updates expected gas usage in test
category/execution/ethereum/test/test_monad_chain.cpp Removes MONAD_NEXT-specific test branch
category/execution/ethereum/execute_transaction_test.cpp Removes MONAD_NEXT-specific refund expectations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

msetrin
msetrin previously approved these changes Oct 27, 2025
@msetrin msetrin requested a review from babelkushal October 28, 2025 02:05
@Baltoli Baltoli force-pushed the bruce/monad-six-pricing branch from baaf536 to cdc39ce Compare October 28, 2025 10:19
babelkushal
babelkushal previously approved these changes Oct 28, 2025
@Baltoli Baltoli dismissed stale reviews from babelkushal and msetrin via 9577023 October 28, 2025 22:51
@Baltoli Baltoli force-pushed the bruce/monad-six-pricing branch from cdc39ce to 9577023 Compare October 28, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants