-
Couldn't load subscription status.
- Fork 374
Update pricing for MONAD_SIX
#1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
50380db to
baaf536
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Monad virtual machine to introduce a new revision MONAD_SIX and shifts pricing changes that were previously assigned to MONAD_NEXT to this new revision. The main purpose is to formalize and version control pricing model updates.
Key Changes:
- Introduces
MONAD_SIXas revision 6 and renumbersMONAD_NEXTto revision 7 - Moves pricing version 1 activation from
MONAD_NEXTtoMONAD_SIX - Simplifies gas refund logic by removing
MONAD_NEXT-specific conditional branches
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| category/vm/evm/monad/revision.h | Adds MONAD_SIX enum value and renumbers MONAD_NEXT |
| category/vm/evm/traits.hpp | Updates pricing version activation and removes obsolete trait methods |
| category/vm/evm/opcodes.hpp | Adds opcode table for MONAD_SIX and simplifies MONAD_NEXT table |
| category/vm/runtime/storage_costs.hpp | Updates storage cost tables to inherit from base traits |
| category/vm/evm/explicit_traits.hpp | Adds template instantiations for MONAD_SIX |
| category/execution/ethereum/execute_transaction.cpp | Simplifies gas refund logic by removing conditional branching |
| category/execution/monad/monad_transaction_gas.cpp | Removes MONAD_NEXT-specific gas refund computation |
| category/execution/ethereum/transaction_gas.cpp | Removes unused refund_gas_price function |
| category/execution/ethereum/transaction_gas.hpp | Removes refund_gas_price function declaration |
| category/execution/monad/monad_transaction_gas.hpp | Removes refund_gas_price function declaration |
| test/vm/unit/evm_tests.cpp | Removes obsolete block gas overflow test |
| category/rpc/eth_call_test.cpp | Updates expected gas usage in test |
| category/execution/ethereum/test/test_monad_chain.cpp | Removes MONAD_NEXT-specific test branch |
| category/execution/ethereum/execute_transaction_test.cpp | Removes MONAD_NEXT-specific refund expectations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baaf536 to
cdc39ce
Compare
cdc39ce to
9577023
Compare
No description provided.