switch precompiles_test tests to TraitsTest #1828
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the precompiles test suite by switching from individual fork-specific test functions to a parameterized TraitsTest approach. This change consolidates tests across different EVM forks (Frontier through Osaka) and Monad revisions into single, trait-parameterized tests.
Key changes:
- Replaced fork-specific
TEST()functions withTYPED_TEST(TraitsTest, ...) - Updated test data structures to use
evmc::bytesand optional fields for more flexible test configuration - Added compile-time fork/revision checks to enable/disable precompile tests appropriately
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
goodlyrottenapple
force-pushed
the
sam/traits_test_precompiles_test
branch
from
a67f690 to
bb5983e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.