Skip to content

Move recover authority logic inside submitted lambda #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move recover authority logic inside submitted lambda #1827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions category/rpc/eth_call.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
#include <category/execution/ethereum/core/transaction.hpp>
#include <category/execution/ethereum/db/trie_rodb.hpp>
#include <category/execution/ethereum/evmc_host.hpp>
#include <category/execution/ethereum/execute_block.hpp>
#include <category/execution/ethereum/execute_transaction.hpp>
#include <category/execution/ethereum/state2/block_state.hpp>
#include <category/execution/ethereum/state3/state.hpp>
Expand Down Expand Up @@ -598,9 +597,6 @@ struct monad_eth_call_executor
return;
}

auto const authorities = recover_authorities({txn}, active_pool.pool);
MONAD_ASSERT(authorities.size() == 1);

active_pool.pool.submit(
eth_call_seq_no,
[this,
Expand All @@ -613,7 +609,6 @@ struct monad_eth_call_executor
block_id = block_id,
&db = db_,
sender = sender,
authorities = authorities[0],
result = result,
complete = complete,
user = user,
Expand All @@ -640,6 +635,15 @@ struct monad_eth_call_executor
complete(result, user);
return;
}

std::vector<std::optional<Address>> authorities(
orig_txn.authorization_list.size());
for (auto j = 0u; j < orig_txn.authorization_list.size();
++j) {
authorities[j] =
recover_authority(orig_txn.authorization_list[j]);
}

auto transaction = orig_txn;

bool const override_with_low_gas_retry_if_oog =
Expand Down
Loading