call process_ethereum_block from monad

[zander-xyz]

No description provided.

[Copilot]

Pull Request Overview

This PR refactors block execution logic by extracting revert transaction generation into a separate module. The primary goal is to improve code modularity by separating Ethereum-specific block processing logic from Monad-specific consensus handling.

Key changes:

• Introduces a new revert_transaction_generator module that encapsulates the logic for creating revert transaction functions based on block cache and chain context
• Refactors process_ethereum_block to accept a revert transaction generator as a parameter, making it more generic and reusable
• Moves BlockCacheEntry and BlockCache type definitions from runloop_monad.cpp to the new module

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
cmd/monad/revert_transaction_generator.hpp	Defines new types and function signature for revert transaction generation
cmd/monad/revert_transaction_generator.cpp	Implements the revert transaction generator with block cache management and chain context setup
cmd/monad/runloop_ethereum.hpp	Adds forward declarations and function signature for process_ethereum_block with revert transaction generator parameter
cmd/monad/runloop_ethereum.cpp	Refactors process_ethereum_block to accept and use revert transaction generator; moves database finalization to caller
cmd/monad/runloop_monad.cpp	Simplifies propose_block by delegating execution to process_ethereum_block with a generated revert transaction function
cmd/CMakeLists.txt	Adds new source and header files to the build configuration

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Unreachable code detected. The function returns on line 95-103, making line 104's return false; statement unreachable and dead code.

Suggested change

return false;