[execution]: Use immutable data structures inside VersionStack<T> #1802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkuehlz
force-pushed
the
kkuehler/immer
branch
from
a8aa59c to
cebd938
Compare
immer provides a clean way for us to minimize the amount of copying in the VersionStack data structure without changing the implementation.
kkuehlz
force-pushed
the
kkuehler/immer
branch
from
cebd938 to
d203843
Compare
jhunsaker
force-pushed
the
kkuehler/hash2
branch
from
f1a077a to
9ac5115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[execution]: Add immer submodule
[execution]: Use immutable DS for types inside of VersionStack