switch test_db tests to TraitsTest #1801
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodlyrottenapple
force-pushed
the
sam/monad_revision_test_test_db
branch
2 times, most recently
from
d25f382 to
6162fdc
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the test_db tests to use a traits-based testing approach, enabling parameterized testing across different Monad and EVM revisions. The changes introduce template-based fixture classes and leverage the TraitsTest infrastructure to run tests against multiple blockchain revision configurations.
Key changes:
- Refactored
traits_test.hppto support customizable template parameters for revision type generation - Converted test fixtures to template-based
TrieDbFixtureTraitsthat work with both Monad and EVM revisions - Migrated specific tests (
call_frames_stress_test,assertion_exception,call_frames_refund) fromDBTesttoDBTraitsTestwith revision-specific logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/unit/common/include/monad/test/traits_test.hpp |
Made revision type generators accept template parameters to support custom type wrappers |
category/execution/ethereum/db/test/test_db.cpp |
Introduced traits-based test fixtures and converted three tests to support multiple revisions with revision-specific assertions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
goodlyrottenapple
force-pushed
the
sam/monad_revision_test_test_db
branch
2 times, most recently
from
342e740 to
33d6807
Compare
Comment on lines
+159
to
+176
| template <typename TDB> | ||
| struct DBTest : public TDB | ||
| { | ||
| }; | ||
|
|
||
| using DBTypes = ::testing::Types<InMemoryTrieDbFixture, OnDiskTrieDbFixture>; | ||
| TYPED_TEST_SUITE(DBTest, DBTypes, RevisionTestNameGenerator); | ||
|
|
||
| template <typename TDB> | ||
| struct DBTraitsTest : public TDB | ||
| { | ||
| }; | ||
|
|
||
| TYPED_TEST_SUITE( | ||
| DBTraitsTest, MonadEvmRevisionDBTypes, RevisionTestNameGenerator); |
There was a problem hiding this comment.
Pulled these out to be reused in category/execution/ethereum/state2/test/test_state.cpp
goodlyrottenapple
force-pushed
the
sam/monad_revision_test_test_db
branch
from
33d6807 to
6a26907
Compare
goodlyrottenapple
force-pushed
the
sam/monad_revision_test_test_db
branch
6 times, most recently
from
4884476 to
ef3873e
Compare
goodlyrottenapple
force-pushed
the
sam/monad_revision_test_test_db
branch
from
ef3873e to
52fa26c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.