-
Couldn't load subscription status.
- Fork 290
Allow higher provider gas limit than block gas limit #2407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes gas limit restrictions that previously capped provider gas limits to the block gas limit for eth_call and eth_estimateGas operations. This allows operators to configure higher gas limits for these operations and manage gas usage independently.
- Removes minimum constraint between provider gas limit and block gas limit in gas estimation
- Removes minimum constraint between provider gas limit and block gas limit in eth_call preparation
- Removes explicit gas limit validation that rejected transactions with gas limits exceeding the block gas limit
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| monad-rpc/src/handlers/eth/gas.rs | Removes provider gas limit constraint in gas estimation |
| monad-rpc/src/handlers/eth/call.rs | Removes provider gas limit constraint in call preparation |
| monad-ethcall/src/lib.rs | Removes gas limit validation that enforced block gas limit ceiling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b3aa14f to
fc16dc2
Compare
a55c748 to
0da142f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in https://github.com/category-labs/monad-bft/blob/pg/gas-provider-limit/monad-rpc/src/handlers/eth/call.rs#L487 we are still upper bounding by block gas limit, will need to remove that upper bound too i think
Operators can set a higher provider gas limit for eth_call and eth_estimateGas and meter usage themselves.
0da142f to
9fbaadc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if provider gas limit is larger than block gas limit, will execution respect the provider gas limit?
Operators can set a higher provider gas limit for eth_call and eth_estimateGas and meter usage themselves.