Refactor experiments page JS to not use jQuery #2531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, fixes #1939: - currently, when text fields repopulate from localstorage on refresh or revisiting the page, special characters were changing to url encoded ones, like spaces were pluses. Fixed. - same scenario, multi-field experiments like find and replace weren't populating from localstorage properly. Fixed. - same scenario, the experiments that have "add More" buttons were only populating the first input. FIxed
stoyan
approved these changes
Nov 9, 2022
Contributor
stoyan
left a comment
stoyan
left a comment
There was a problem hiding this comment.
Awesome, thanks! Few nits inline.
And don't forget to run composer format:prettier
| } | ||
| }); | ||
| } | ||
| var input = form.querySelector("textarea[name='" + keyval[0] + "']:not([data-hydrated='true']),input[type='text'][name='" + keyval[0] + "']:not([data-hydrated='true'])"); |
Contributor
There was a problem hiding this comment.
I wonder if these queries will be more readable as templates
form.querySelector(`textarea[name='${keyval[0]}']:not([data-...`);
Contributor
Author
There was a problem hiding this comment.
hmm yeah maybe? I left them for now... we could revisit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, fixes #1939: