fix(header): allow tests to pass #2500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, globals come through as null in phpunit, we could likely set "backupGlobals" to false in the config, but I don't know that I want to do that, so here's a fallback that gives us a little coverage If we ever need to write this test so we see the rendering differences for paid users, we'll need a better setup than this
tkadlec
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, globals come through as null in phpunit, we could likely set "backupGlobals" to false in the config, but I don't know that I want to do that, so here's a fallback that gives us a little coverage
If we ever need to write this test so we see the rendering differences for paid users, we'll need a better setup than this