Replaced glossary table with a definition list #2461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefflembeck
reviewed
Oct 18, 2022
| echo '<h3 class="hed_sub">Optimization Details</h3>'; | ||
| dumpOptimizationGlossary(); | ||
| require_once __DIR__ . '/resources/view.php'; | ||
| echo view('snippets.glossary', []); |
Contributor
There was a problem hiding this comment.
Do we want to namespace view so we can use use with it?
Contributor
Author
There was a problem hiding this comment.
hmm, maybe. The thing is it's like this in Laravel so I thought it'd be easier to replace.
Also /resources/view.php is now autoloaded in a newer PR so view() would be just a globally accessible function like it is in Laravel: https://laravel.com/docs/9.x/blade#introduction
jefflembeck
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization glossary table looked a bit dated (smaller font) and glitchy to render (see #2452), so replaced it with a
<dl>. Also deleted CSS fortable.glossary, it wasn't used.Any comments appreciated regarding content (didn't touch it) or formatting.
Before:
(no rendering till scroll)
(scroll)
After: