A round of dead PHP code fixes #2451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeenan
requested changes
Oct 10, 2022
Contributor
pmeenan
left a comment
pmeenan
left a comment
There was a problem hiding this comment.
Mostly looks good but I think the grayscale logic removal was incorrect and the math issue noted in the comments as well. The video.inc video script logic can probably be removed entirely but that's probably better done as a separate PR.
Make sure to test it out on a dev server, particularly poking around at filmstrips and videos because that looks like where most of the logic was removed.
Contributor
Author
|
Thanks for the thorough review, @pmeenan, this is awesome! |
pmeenan
approved these changes
Oct 11, 2022
Contributor
|
LGTM, thanks for the cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran a tool called PHPMD to look for unused variables
Looked around the output and partially applied changes where VSCode's PHP Intelephense seemed to agree with phpmd and changes looked safe, especially careful with the use of globals