Skip to content

Added a checkbox for script injection to use Chrome's native support #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jefflembeck merged 1 commit into from
Oct 6, 2022
Merged

Added a checkbox for script injection to use Chrome's native support #2437

jefflembeck merged 1 commit into from
Oct 6, 2022

Conversation

@pmeenan
Copy link
Contributor

@pmeenan pmeenan commented Oct 6, 2022

This is a rebasing of #1847

@pmeenan pmeenan mentioned this pull request Oct 6, 2022
Closed
@pmeenan pmeenan requested review from stoyan and tkadlec October 6, 2022 17:44
stoyan
stoyan approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@stoyan stoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jefflembeck jefflembeck merged commit 771a8fb into catchpoint:master Oct 6, 2022
@pmeenan pmeenan deleted the inject2 branch October 7, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tkadlec tkadlec Awaiting requested review from tkadlec

1 more reviewer

@stoyan stoyan stoyan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmeenan @stoyan @jefflembeck