Skip to content

Add vitals links to metrics table if all three are collected. #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scottjehl merged 1 commit into from
Jan 27, 2022
Merged

Add vitals links to metrics table if all three are collected. #1685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions www/include/RunResultHtmlTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,7 @@ private function _createHead() {
// $out .= $this->_headCell("", "empty", $colspan);

// // Count the web vitals metrics that we have
// $test_id = $this->testInfo->getId();
// $run = $this->runResults->getRunNumber();
// $cached = $this->runResults->isCachedRun() ? '1' : '0';
// $vitals_url = htmlspecialchars("/vitals.php?test=$test_id&run=$run&cached=$cached");

// $vitals_count = 0;
// if ($this->isColumnEnabled(self::COL_LARGEST_CONTENTFUL_PAINT)) {
// $vitals_count++;
Expand Down Expand Up @@ -173,6 +170,16 @@ private function _createHead() {
$out .= $this->_headCell("Result (error code)");
}
$vitalsBorder = "border";
//for now, only provide a link to vitals if all metrics are collected
if ($this->isColumnEnabled(self::COL_LARGEST_CONTENTFUL_PAINT) &&
$this->isColumnEnabled(self::COL_CUMULATIVE_LAYOUT_SHIFT) &&
$this->isColumnEnabled(self::COL_TOTAL_BLOCKING_TIME)) {
$test_id = $this->testInfo->getId();
$run = $this->runResults->getRunNumber();
$cached = $this->runResults->isCachedRun() ? '1' : '0';
$vitals_url = htmlspecialchars("/vitals.php?test=$test_id&run=$run&cached=$cached");
}

if ($this->isColumnEnabled(self::COL_LARGEST_CONTENTFUL_PAINT)) {
$out .= $this->_headCell("<a href='$vitals_url#lcp'><abbr title='Largest Contentful Paint'>LCP</abbr></a>", $vitalsBorder);
$vitalsBorder = null;
Expand Down