feat(design): removing compact mode #1648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With our responsive design overhaul, compact mode doesn't mesh well (and isn't really necessary). It also creates more code overhead to parse/work through.
jefflembeck
requested review from
scottjehl and
tkadlec
and removed request for
tkadlec
tkadlec
previously requested changes
Dec 16, 2021
Contributor
tkadlec
left a comment
tkadlec
left a comment
There was a problem hiding this comment.
Looks good!
Can we also kill any .compact styles in pagestyles2.css while we're at it? Just to clean it up there a bit too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With our responsive design overhaul, compact mode doesn't mesh well (and
isn't really necessary). It also creates more code overhead to parse/work
through.