feat: month-based rate limiter #1600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This here monthly rate limiter class is a quick and dirty way to make sure we don't get hit by more than 50 tests from a specific IP address of an anonymous user in a 31 day period. We can set those numbers to higher numbers or lower numbers, though. This should probably be done with something sturdier (see: redis), but for right now uses the APCU plugin, which is what we use for our rate limiting for 3 minute long periods already. It will lose track of things when the machine gets restarted but I don't think we care _that_ much, for now.
scottjehl
approved these changes
Oct 28, 2021
Contributor
scottjehl
left a comment
scottjehl
left a comment
There was a problem hiding this comment.
This looks fantastic. Great work, @jefflembeck
tkadlec
approved these changes
Oct 28, 2021
Contributor
tkadlec
left a comment
tkadlec
left a comment
There was a problem hiding this comment.
Rock-solid work @jefflembeck! And moar tests! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This here monthly rate limiter class is a quick and dirty way to make
sure we don't get hit by more than 50 tests from a specific IP address
of an anonymous user in a 31 day period. We can set those numbers to
higher numbers or lower numbers, though.
This should probably be done with something sturdier (see: redis), but for
right now uses the APCU plugin, which is what we use for our rate
limiting for 3 minute long periods already. It will lose track of things
when the machine gets restarted but I don't think we care that much,
for now.