1452: Clean up custom waterfall settings form #1535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… form as a panel. HTML cleanup included
…utton in the header. this allows viewing the whole waterfall. #1452
…es for settings pane
…de of the header context. add a download link after the custom waterfall image.
Contributor
|
This is looking great! Can you have a quick look at it in Safari to see why the icon is off to the left? Not a huge issue, but would be nice to line that more like it is elsewhere.
When that's set, I think we're ready to merge! |
Contributor
Author
|
Ah, yeah! Weird one. I'll take a look now. Thanks Tim :) |
… flex layout on a summary element? ugh.
Contributor
|
Looking rock solid to me! (Darn Safari) Shipping. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page could still use some cleaning up but, some changes relevant to this particular ticket (#1452):
This update includes:
Note: for the download link, I reused the existing pill style, which needed an explicit color added, hence the version bump.
fixes #1452