Move header from internal #2972
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `catch_test_run_info.hpp` from directory `src/catch2/internal/` to be directly under `src/catch2/`. Header `catch_test_run_info.hpp` defines `Catch::TestRunInfo` which is part of the public API, since it is required when overriding `Catch::EventListenerBase`. Fixes issue caught by Clang Tidy misc-include-cleaner check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2972 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 198 198
Lines 8599 8599
=======================================
Hits 7826 7826
Misses 773 773 🚀 New features to boost your workflow:
|
neheb
approved these changes
Apr 17, 2025
shahsb
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
catch_test_run_info.hppfrom directorysrc/catch2/internal/to be directly undersrc/catch2/.Header
catch_test_run_info.hppdefinesCatch::TestRunInfowhich is part of the public API, since it is required when overridingCatch::EventListenerBase.Fixes issue caught by Clang Tidy misc-include-cleaner check.