Fix CMake regex in ParseAndAddCatchTest helper

[NeroBurner]

Description

Fix regex that requires two string arguments in the form of
TEST_CASE("a", "b") resulting in not finding TEST_CASE("a") entries.

See regex: https://regex101.com/r/rQe6Jd/1

GitHub Issues

Fixes: #2055

[codecov]

Codecov Report

Merging #2056 into v2.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v2.x    #2056   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files         138      138           
  Lines        5651     5651           
=======================================
  Hits         5015     5015           
  Misses        636      636           

[horenmar]

Honestly this calls for a proper parser, because the new regex breaks TEMPLATE_TEST_CASE instead:

https://regex101.com/r/rQe6Jd/2

[NeroBurner]

Do you maybe also have an idea on how we could add tests for the parser, that such oversights are covered by the test cases?

[horenmar]

I'd go with having a separate CMake project that uses the parser for a known source file, and a Python script that first configures the project, and then runs ctest -N and checks that the output lists all tests.

[NeroBurner]

updated the regex to cover the template cases https://regex101.com/r/JygOND/1

[horenmar]

Okay, looks fine.

However, I can't help but think of the regex, two problems saying. 😃

[horenmar]

I just noticed that you target master branch. Don't, it is dead, I just kept it around for a while in case something broke too terribly after I changed the default branch.

For v2 branch target v2.x, for current development target devel.

Don't worry about the already merged PR, I'll cherry-pick it into the right branch later.

[NeroBurner]

changed it, thanks for the heads up