Support sentinel-based ranges in default stringify - #2004
Merged
Conversation
Member
|
Tests in default run cannot fail, or it will fail CI. Instead, you should use |
Contributor
Author
|
Ah, gotcha. Easy enough to fix, thanks. |
Contributor
Author
|
@horenmar - I'm not familiar with the approval test stuff here; should I be checking in the files that are modified locally on build? |
Member
|
On a second look, this part seems to be missing from the documentation after the rewrite. 🤔 Approval tests diff known good output with current output. If there are changes, check that the diff makes sense, run |
Codecov Report
@@ Coverage Diff @@
## master #2004 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 138 138
Lines 5648 5648
=======================================
Hits 5013 5013
Misses 635 635 |
Member
|
Looks good now, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #2003
rangeToStringto work with a separate iterator and sentinel type