Skip to content

Support sentinel-based ranges in default stringify - #2004

Merged
horenmar merged 4 commits into
catchorg:masterfrom
seanmiddleditch:sentinels
Aug 18, 2020
Merged

Support sentinel-based ranges in default stringify#2004
horenmar merged 4 commits into
catchorg:masterfrom
seanmiddleditch:sentinels

Conversation

@seanmiddleditch

Copy link
Copy Markdown
Contributor

Fix for issue #2003

  • Enhances rangeToString to work with a separate iterator and sentinel type
  • Adds a test to ensure this compiles

@horenmar

Copy link
Copy Markdown
Member

Tests in default run cannot fail, or it will fail CI. Instead, you should use ::Catch::Detail::stringify in the test and check that the return value matches expected stringification.

@seanmiddleditch

seanmiddleditch commented Aug 14, 2020

Copy link
Copy Markdown
Contributor Author

Ah, gotcha. Easy enough to fix, thanks.

@seanmiddleditch

Copy link
Copy Markdown
Contributor Author

@horenmar - I'm not familiar with the approval test stuff here; should I be checking in the files that are modified locally on build?

@horenmar

Copy link
Copy Markdown
Member

On a second look, this part seems to be missing from the documentation after the rewrite. 🤔

Approval tests diff known good output with current output. If there are changes, check that the diff makes sense, run scripts/approve.py and commit the updated baselines.

@codecov

codecov Bot commented Aug 16, 2020

Copy link
Copy Markdown

Codecov Report

Merging #2004 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2004   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         138      138           
  Lines        5648     5648           
=======================================
  Hits         5013     5013           
  Misses        635      635           

@horenmar

Copy link
Copy Markdown
Member

Looks good now, thanks.

@horenmar
horenmar merged commit 284672c into catchorg:master Aug 18, 2020
@seanmiddleditch
seanmiddleditch deleted the sentinels branch August 18, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants