Issue 1992: Better c++17 std::byte detection - #1996
Merged
Merged
Conversation
This fixed buld errors for ubuntu-16 + clang and similar situations where C++17 is supported in the compiler but not the default C++ standard library.
Codecov Report
@@ Coverage Diff @@
## master #1996 +/- ##
=======================================
Coverage 88.75% 88.75%
=======================================
Files 138 138
Lines 5651 5651
=======================================
Hits 5015 5015
Misses 636 636 |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixed buld errors for ubuntu-16 + clang and similar situations
where C++17 is supported in the compiler but not the default
C++ standard library.
Description
Clang packages on ubuntu-16 use the clang compiler which supports C++17, but use the system-default C++ library which does not fully support C++17. This results in compile errors where Catch2 mis-identifies support for std::bytes.
GitHub Issues
Closes #1992