Fix non-default-constructible type lists used in TEMPLATE_LIST_TEST_CASE#1697
Merged
horenmar merged 2 commits intocatchorg:masterfrom Jul 22, 2019
Merged
Conversation
std::tuple is not default constructible when the first type is not default-constuctible. Therefore it can not be instantiated. to circumvent this, we have to use std::declval in the unevaluate decltype context.
Codecov Report
@@ Coverage Diff @@
## master #1697 +/- ##
==========================================
- Coverage 86.18% 83.91% -2.27%
==========================================
Files 136 123 -13
Lines 5180 3405 -1775
==========================================
- Hits 4464 2857 -1607
+ Misses 716 548 -168 |
Codecov Report
@@ Coverage Diff @@
## master #1697 +/- ##
=======================================
Coverage 86.18% 86.18%
=======================================
Files 136 136
Lines 5180 5180
=======================================
Hits 4464 4464
Misses 716 716 |
Member
|
Looks good, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::tuple is not default constructible when the first type is not
default-constuctible. Therefore it can not be instantiated.
To circumvent this, we have to use std::declval in the unevaluate decltype
context.