WIN32 not defined yet

[matt77hias]

Hey, I have some possible (as I manually configure MSBuild) compilation on Windows 10 (VS2019).

internal\catch_session.h

#if defined(CATCH_CONFIG_WCHAR) && defined(WIN32) && defined(UNICODE)
        int applyCommandLine( int argc, wchar_t const * const * argv );
#endif

WIN32 is not defined (yet).

internal\catch_session.cpp

#if defined(CATCH_CONFIG_WCHAR) && defined(WIN32) && defined(UNICODE)
    int Session::applyCommandLine( int argc, wchar_t const * const * argv ) {
...
    }
#endif

WIN32 is defined.

Solution: move #include "catch_windows_h_proxy.h" before "#include "catch_session.h".

I am running the trunk version.

[horenmar]

Upon closer inspection, the macro used should _WIN32, but given the other issues you've opened, it seems that your build is fundamentally broken.

[JoeyGrajciar]

Are you including header from single_include/catch2 folder? or from include folder?

[matt77hias]

I will provide a minimal example containing the VS2019 solution later today. Basically, I just build a static lib (so not the header-only version) and link against that for my test executable. The latter originally used doctest, but I replaced that with all the corresponding Catch2 includes and macros. Building the lib and exe succeeds.

…

On Sat, Jul 6, 2019, 12:13 Jozef Grajciar ***@***.***> wrote: Are you including header from single_include/catch2 folder? or from include folder? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1676?email_source=notifications&email_token=AASZSE3UY5ACNDSZLLAXNSDP6BV5NA5CNFSM4H56RPL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKWVZA#issuecomment-508914404>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASZSEZ6TLFUO5UBKBPCYXLP6BV5NANCNFSM4H56RPLQ> .