Assertion fails during nlohmann/json tests

[yurivict]

Tests in https://github.com/nlohmann/json version 3.1.2 fail on FreeBSD due to assertions in catch2: nlohmann/json#1032 (comment)

[nlohmann]

We haven't seen a Catch assertion fail in years - this seems to be an issue related to FreeBSD.

For reference:

Assertion failed: (m_parent), function moveToParent, file /usr/ports/devel/nlohmann-json/work/json-3.1.2/test/thirdparty/catch/catch.hpp, line 6222.

That's this line.

Note we are still using Catch v1.9.7 as porting all tests to Catch 2 is still an issue. Nevertheless, it would be interesting to understand what the reported assertion means and if there is a bug somewhere.

[horenmar]

@yurivict Can you check what happens when you run Catch's self-test on FreeBSD?

[yurivict]

Yes, there are assertions:

loose text artifact
===============================================================================
All tests passed (854 assertions in 142 test cases)

Version 2.2.1

[yurivict]

Now I am trying to update the FreeBSD port devel/nlohmann-json and Catch is still failing in tests.

Any hope to resolve this?

[grembo]

This is caused by nlohmann-json using duplicate section names in loops, basically the problem described here: #816 (comment)

You can probably close this issue, as this is not caused by catch, but by an invalid use of it.

[grembo]

The fix in nlohmann-json has been merged. This is neither a catch2 nor a FreeBSD issue, you can really close it now.

[horenmar]

I have been a bit busy so I didn't notice that it has been resolved since. I am going to tag this with a "Revisit" label, to check if we can report this to the user somehow.

Thank you for reporting back.