Explicitly specify obj_dir #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without that, phpize builds fail because there is rar.c and rar.cpp, and both are compiled to rar.obj in the same folder. This appears to be an upstream bug[1], but even if so, that won't be fixed for PHP 7 anymore, so we work around. [1] <https://github.com/php/php-src/blob/php-8.1.0/win32/build/confutils.js#L1617-L1625>
cmb69
added a commit
to cmb69/php-rar
that referenced
this pull request
Nov 30, 2021
While there is already an AppVeyor CI, the problem with that is that usually only one job runs in parallel, but we want to be able to run the builds for multiple PHP versions. For now, we just run for PHP 7.4, though, since some stuff needs to be fixed, e.g. cataphract#13, and the failing tests[1]. [1] <https://github.com/cmb69/php-rar/runs/4370012547>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without that, phpize builds fail because there is rar.c and rar.cpp,
and both are compiled to rar.obj in the same folder. This appears to
be an upstream bug[1], but even if so, that won't be fixed for PHP 7
anymore, so we work around.
[1] https://github.com/php/php-src/blob/php-8.1.0/win32/build/confutils.js#L1617-L1625