Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MiniscopeImagingExtractor #225

Merged
merged 20 commits into from
Jun 14, 2023
Merged

Conversation

weiglszonja
Copy link
Contributor

@weiglszonja weiglszonja commented May 31, 2023

Add extractor for the Miniscope format:

  • MiniscopeImagingExtractor takes a folder_path that points to the main folder where the microscope and behavior video subfolders are located.

The expected folder structure for Miniscope V3 recordings, based on the example session received from the Tye lab, is organized as follows:

  • C6-J588_Disc5/ (main folder)
    • 15_03_28/ (subfolder corresponding to the recording time)
      • Miniscope/ (subfolder containing the microscope video stream)
        • 0.avi (file containing the microscope video)
        • metaData.json (file containing the metadata for the microscope device)

@weiglszonja weiglszonja marked this pull request as draft May 31, 2023 13:33
requirements-full.txt Outdated Show resolved Hide resolved
@CodyCBakerPhD
Copy link
Member

Mostly looks good; is there an example file to share yet?

weiglszonja and others added 4 commits June 5, 2023 11:21
…nto add_MiniscopeImagingExtractor

# Conflicts:
#	src/roiextractors/extractors/miniscopeimagingextractor/miniscopeimagingextractor.py
@CodyCBakerPhD
Copy link
Member

Not seeing any more dependency conflicts in 3.8, just testing errors

@CodyCBakerPhD
Copy link
Member

From meeting: dropping 3.7 here

@weiglszonja Can you try adding 3.11 in a follow-up just to see if it works?

@CodyCBakerPhD
Copy link
Member

@weiglszonja Just checked the latest example file

The OnePhotonSeries data field is still float64

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review June 14, 2023 13:58
@weiglszonja
Copy link
Contributor Author

@CodyCBakerPhD Thanks for checking the file, turned out I was using an roiextractors version the commit before I fixed the data type issue.
The example file has been replaced, now it is showing up as uint8 values.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #225 (4b98133) into main (062f69e) will increase coverage by 0.68%.
The diff coverage is 98.52%.

❗ Current head 4b98133 differs from pull request most recent head 2a19ed3. Consider uploading reports for the commit 2a19ed3 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   75.45%   76.14%   +0.68%     
==========================================
  Files          35       37       +2     
  Lines        2514     2582      +68     
==========================================
+ Hits         1897     1966      +69     
+ Misses        617      616       -1     
Flag Coverage Δ
unittests 76.14% <98.52%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...scopeimagingextractor/miniscopeimagingextractor.py 98.48% <98.48%> (ø)
src/roiextractors/extractorlist.py 100.00% <100.00%> (ø)
...s/extractors/miniscopeimagingextractor/__init__.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge June 14, 2023 17:41
@CodyCBakerPhD CodyCBakerPhD merged commit 813d653 into main Jun 14, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the add_MiniscopeImagingExtractor branch June 14, 2023 17:41
@CodyCBakerPhD
Copy link
Member

Awesome! Thanks for all the work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants