-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MiniscopeImagingExtractor
#225
Conversation
for more information, see https://pre-commit.ci
src/roiextractors/extractors/miniscopeimagingextractor/miniscopeimagingextractor.py
Outdated
Show resolved
Hide resolved
Mostly looks good; is there an example file to share yet? |
…nto add_MiniscopeImagingExtractor # Conflicts: # src/roiextractors/extractors/miniscopeimagingextractor/miniscopeimagingextractor.py
for more information, see https://pre-commit.ci
src/roiextractors/extractors/miniscopeimagingextractor/miniscopeimagingextractor.py
Outdated
Show resolved
Hide resolved
…nto add_MiniscopeImagingExtractor
Not seeing any more dependency conflicts in 3.8, just testing errors |
From meeting: dropping 3.7 here @weiglszonja Can you try adding 3.11 in a follow-up just to see if it works? |
@weiglszonja Just checked the latest example file The OnePhotonSeries data field is still |
@CodyCBakerPhD Thanks for checking the file, turned out I was using an roiextractors version the commit before I fixed the data type issue. |
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 75.45% 76.14% +0.68%
==========================================
Files 35 37 +2
Lines 2514 2582 +68
==========================================
+ Hits 1897 1966 +69
+ Misses 617 616 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Awesome! Thanks for all the work on this |
Add extractor for the Miniscope format:
MiniscopeImagingExtractor
takes afolder_path
that points to the main folder where the microscope and behavior video subfolders are located.The expected folder structure for Miniscope V3 recordings, based on the example session received from the Tye lab, is organized as follows:
C6-J588_Disc5/
(main folder)15_03_28/
(subfolder corresponding to the recording time)Miniscope/
(subfolder containing the microscope video stream)0.avi
(file containing the microscope video)metaData.json
(file containing the metadata for the microscope device)