Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtractSegmentationExtractor improvements #210

Merged
merged 15 commits into from
Sep 7, 2022

Conversation

weiglszonja
Copy link
Contributor

@weiglszonja weiglszonja commented Sep 5, 2022

Connected to catalystneuro/neuroconv#128, raise an error when output_struct_name is not found in the .mat file.

  • changed assumed newer version of extract files to "1.0.0"
  • transpose segmentation images to have height x width for consistency

@weiglszonja weiglszonja added the enhancement New feature or request label Sep 5, 2022
@weiglszonja weiglszonja self-assigned this Sep 5, 2022
@weiglszonja weiglszonja marked this pull request as draft September 5, 2022 12:16
…mprovements' into extract_segmentation_extractor_improvements
@CodyCBakerPhD
Copy link
Member

transpose segmentation images to have height x width for consistency

From the tutorial at: https://github.com/schnitzer-lab/EXTRACT-public/blob/master/Learning%20materials/Lecture%20Tutorials/Tutorial%201%20-%20Starting%20code/example_tutorial.m#L38

it would seem the spatial weights already follow ROIExtractors convention

@weiglszonja
Copy link
Contributor Author

@CodyCBakerPhD leaving here as a reminder
when reading extract data in MATLAB, these images would read as height x width; however in h5py they would read as width x height by default, hence the transpose is necessary in this case to be consistent within extractors.

@weiglszonja weiglszonja marked this pull request as ready for review September 7, 2022 16:55
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #210 (52f2643) into master (f9c3041) will increase coverage by 0.14%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   73.04%   73.19%   +0.14%     
==========================================
  Files          33       33              
  Lines        2282     2294      +12     
==========================================
+ Hits         1667     1679      +12     
  Misses        615      615              
Flag Coverage Δ
unittests 73.19% <96.66%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...schnitzerextractor/extractsegmentationextractor.py 94.77% <96.66%> (+0.44%) ⬆️

@CodyCBakerPhD CodyCBakerPhD merged commit ac88a8c into master Sep 7, 2022
@CodyCBakerPhD CodyCBakerPhD deleted the extract_segmentation_extractor_improvements branch September 7, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants