Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test spikeinterface-like behavior for get_video with one element #181

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Jul 24, 2022

This is something important for the chunk iterator that is being developed by @weiglszonja. Note that this should be merged after #180 as it has it as a base.

@h-mayorquin h-mayorquin self-assigned this Jul 24, 2022
Base automatically changed from make_get_video_an_abstract_method to master July 24, 2022 21:38
@CodyCBakerPhD
Copy link
Member

Great, anything else to add?

@h-mayorquin
Copy link
Collaborator Author

Great, anything else to add?

@CodyCBakerPhD @weiglszonja
I don't know if you care about the case when start_frame == end frame, in that case spikeinterface returns an array of shape (0, num_channels). Is that a edge case of the iterator you are building? What do you think?

@h-mayorquin h-mayorquin marked this pull request as ready for review July 25, 2022 06:44
@CodyCBakerPhD
Copy link
Member

I don't know if you care about the case when start_frame == end frame, in that case spikeinterface returns an array of shape (0, num_channels). Is that a edge case of the iterator you are building? What do you think?

The slicing semantics of the GenericDataChunkIterator should not have an issue with endpoints like that but good to think of...

So in SpikeInterface, if you want to get all channel data for a single frame, you need to slice from start_frame to start_frame+1? And to access the final frame that way you would need to do from final_frame to final_frame+1?

@h-mayorquin
Copy link
Collaborator Author

So in SpikeInterface, if you want to get all channel data for a single frame, you need to slice from start_frame to start_frame+1? And to access the final frame that way you would need to do from final_frame to final_frame+1?

start_frame=0, end_frame=1 -> you get the first frame
start_frame=last_frame - 1, end_frame=last_frame -> you get the last frame

@CodyCBakerPhD CodyCBakerPhD merged commit 558baa2 into master Jul 25, 2022
@CodyCBakerPhD CodyCBakerPhD deleted the test_spikeinterface_like_behavior branch July 25, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants