Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy segmentation extractor #176

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

h-mayorquin
Copy link
Collaborator

I am adding this as a general testing tool that will help us with the testing and refactoring of the segmentation interfaces in nwb conversion tools. The code is documented and has a simple test with it.

I also changed other small mistakes, errors in the code such as wrong documentation in the base class and inconsistent typing requirements in the NumpySegmentationExtractor

@h-mayorquin h-mayorquin added enhancement New feature or request testing labels Jul 19, 2022
@h-mayorquin h-mayorquin self-assigned this Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #176 (5282f3a) into master (4ba3c56) will increase coverage by 2.13%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   71.04%   73.18%   +2.13%     
==========================================
  Files          33       33              
  Lines        2069     2088      +19     
==========================================
+ Hits         1470     1528      +58     
+ Misses        599      560      -39     
Flag Coverage Δ
unittests 73.18% <95.65%> (+2.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/roiextractors/segmentationextractor.py 85.55% <ø> (ø)
src/roiextractors/testing.py 99.24% <95.23%> (-0.76%) ⬇️
...tors/extractors/numpyextractors/numpyextractors.py 60.47% <100.00%> (+23.95%) ⬆️

@h-mayorquin h-mayorquin requested a review from weiglszonja July 19, 2022 14:21
@h-mayorquin h-mayorquin merged commit dce548a into master Jul 19, 2022
@h-mayorquin h-mayorquin deleted the add_dumy_segmentation_extractor branch July 19, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants