Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Databeta #956

Merged
merged 6 commits into from
Mar 26, 2021
Merged

Databeta #956

merged 6 commits into from
Mar 26, 2021

Conversation

zaneselvans
Copy link
Member

This is a grab-bag of minor test / doc / bugfix changes that came up in attempting to put together the data beta.

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #956 (62cbfc8) into dev (0a32f62) will decrease coverage by 0.06%.
The diff coverage is 86.96%.

❗ Current head 62cbfc8 differs from pull request most recent head e9701d0. Consider uploading reports for the commit e9701d0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #956      +/-   ##
==========================================
- Coverage   83.53%   83.47%   -0.06%     
==========================================
  Files          47       47              
  Lines        5573     5583      +10     
==========================================
+ Hits         4655     4660       +5     
- Misses        918      923       +5     
Impacted Files Coverage Δ
src/pudl/workspace/datastore.py 68.83% <0.00%> (-1.91%) ⬇️
src/pudl/cli.py 47.83% <66.67%> (ø)
src/pudl/analysis/service_territory.py 35.92% <100.00%> (+0.63%) ⬆️
src/pudl/convert/censusdp1tract_to_sqlite.py 91.67% <100.00%> (+0.24%) ⬆️
src/pudl/convert/datapkg_to_rst.py 59.38% <100.00%> (+5.80%) ⬆️
src/pudl/convert/datapkg_to_sqlite.py 63.89% <100.00%> (ø)
src/pudl/convert/epacems_to_parquet.py 92.86% <100.00%> (ø)
src/pudl/convert/ferc1_to_sqlite.py 45.83% <100.00%> (+1.15%) ⬆️
src/pudl/transform/ferc1.py 91.21% <100.00%> (+0.03%) ⬆️
src/pudl/workspace/setup_cli.py 54.05% <100.00%> (+1.28%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a32f62...e9701d0. Read the comment docs.

@aesharpe aesharpe self-requested a review March 26, 2021 22:25
Copy link
Member

@aesharpe aesharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! one tiny comment re: name of the metadata rst page

@@ -1,5 +1,5 @@
===============================================================================
All PUDL Database Tables
PUDL Database Index
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be more clear to have "table" in there ex: PUDL Database Table Index or something like that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I went back and forth on that, but then it had both the Tables & Columns, and I didn't want it to seem like it only had Tables. I'll make it more descriptive.

@zaneselvans zaneselvans merged commit c42926f into dev Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants