-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Databeta #956
Databeta #956
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #956 +/- ##
==========================================
- Coverage 83.53% 83.47% -0.06%
==========================================
Files 47 47
Lines 5573 5583 +10
==========================================
+ Hits 4655 4660 +5
- Misses 918 923 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! one tiny comment re: name of the metadata rst page
docs/pudl_db_index.rst
Outdated
@@ -1,5 +1,5 @@ | |||
=============================================================================== | |||
All PUDL Database Tables | |||
PUDL Database Index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be more clear to have "table" in there ex: PUDL Database Table Index or something like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I went back and forth on that, but then it had both the Tables & Columns, and I didn't want it to seem like it only had Tables. I'll make it more descriptive.
This is a grab-bag of minor test / doc / bugfix changes that came up in attempting to put together the data beta.