Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate final 2023 EIA 860 data #3871

Merged
merged 10 commits into from
Sep 30, 2024
Merged

Integrate final 2023 EIA 860 data #3871

merged 10 commits into from
Sep 30, 2024

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Sep 26, 2024 •
edited
Loading

Overview

Closes #3684.

What problem does this address?

Integrates EIA 860 2023 final data.

What did you change?

Steps are tracked in #3684. Notable changes:

Documentation

Make sure to update relevant aspects of the documentation.

Tasks
Beta Give feedback

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list
Beta Give feedback

@e-belfer e-belfer added the eia860 Anything having to do with EIA Form 860 label Sep 26, 2024
@e-belfer e-belfer self-assigned this Sep 26, 2024
@e-belfer e-belfer linked an issue Sep 26, 2024 that may be closed by this pull request
Integrate EIA860 2023 Final Release Data #3684
Closed
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@e-belfer e-belfer marked this pull request as ready for review September 30, 2024 14:50
zaneselvans
zaneselvans reviewed Sep 30, 2024
View reviewed changes
docs/release_notes.rst Outdated
Comment on lines 12 to 15
EIA 923
~~~~~~~
* Added EIA 923 final release data from 2023. See :issue:`3684` and PR :pr:`3871`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the EIA-860 right? Maybe you had 923 on the brain this morning with the archiver false alarm.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 100% a foolish copy-paste error I'll fix!

cmgosnell
cmgosnell requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@cmgosnell cmgosnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks chill! the docs updates are a good change here. the row count updates look good. my only request is about utility_id_pudl.csv. plus to update the form in the release notes!

src/pudl/output/eia.py
# These are five known generators that originate from harvesting the plant and
# These are three known generators that originate from harvesting the plant and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5->3 🎉

src/pudl/package_data/glue/utility_id_pudl.csv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know why this file diff is so big? it looks like maybe the capacity column got added in there as an unnamed column. Maybe that's it? if so it'd be good to delete it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few matches for older PUDL IDs during the matching process, so there's a large reassignment of the PUDL ID # as a result. Also noted that all these records were added as "EIA 860 Final Release 2023" in the notes column

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm but before this pr this CSV does not have a notes column. and it looks like there are just a handful of records in this new unnamed column with a float that looks like the capacity - which we normally don't keep in here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just quickly downloaded the csv and it looks like its just 75 rows in that last column.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I was looking at the xlsx and not the CSV! You're totally right, I'll remove it.

cmgosnell
cmgosnell approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@cmgosnell cmgosnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit but it looks great ty for csv cleaning!!

src/pudl/package_data/glue/utility_id_pudl.csv Outdated
4827,,,60352,"Golden Fields Solar I, LLC"
4316,,,60352,"Golden Fields Solar I, LLC"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bit of a nit but it looks like this one is also up above in the file. can we just remove it?

@e-belfer e-belfer added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 7cff938 Sep 30, 2024
19 checks passed
@e-belfer e-belfer deleted the eia860-2023-final branch September 30, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaneselvans zaneselvans zaneselvans left review comments

@cmgosnell cmgosnell cmgosnell approved these changes

@aesharpe aesharpe Awaiting requested review from aesharpe

Assignees

@e-belfer e-belfer

Labels
eia860 Anything having to do with EIA Form 860
Projects
Catalyst Megaproject
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate EIA860 2023 Final Release Data
3 participants
@e-belfer @zaneselvans @cmgosnell