-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NREL ATB axtraction #3498
NREL ATB axtraction #3498
Conversation
hm i accidentally made this branch off of my unfinished eia extraction branch... i think it's okay now but i probably should have done something besides merge in main... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two smallish blocking changes:
- Please add any ATB docs that you're referencing into our
data_sources
folder. - Suggested changes to the extraction test to actually test the rename, rather than skipping it.
Otherwise extraction works great and as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go!
Overview
Closes #3468.
What did you change?
raw_df_factory
Remaining Questions?
ParquetExtractor
assumes that the archive is one non-zipped file per partition?any_year
in the column maps. I like that convention overall. If we made it a little more general likeany
orany_part
i could imagine adding this default behavior into the generic extractor. I didn't do that only bc it felt oos here.Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list