Tell setuptools_scm to ignore non-version tags #3193
Conversation
| @@ -150,6 +150,16 @@ include-package-data = true | |||
| where = ["src"] | |||
|
|
|||
| [tool.setuptools_scm] | |||
| tag_regex = "^v(?P<version>20\\d{2}\\.\\d{1,2}\\.\\d{1,2})$" | |||
There was a problem hiding this comment.
This tells setuptools_scm how to extract the "version" string.
- Require 4 digit year
- Allows 1 or 2 digit month and day strings (since PyPI and some other tools seem to default to 1 digit rather than allowing a leading zero)
| git_describe_command = [ | ||
| "git", | ||
| "describe", | ||
| "--dirty", | ||
| "--tags", | ||
| "--long", | ||
| "--match", | ||
| "v20*", | ||
| ] |
There was a problem hiding this comment.
This changes the command which is used by setuptools_scm to gather information from git about the tags and current state of the repository. By using the v20* glob, it will only search for tags which match our current versioning scheme.
There was a problem hiding this comment.
We can deal with the eventual failure in 77 years :)
| markers = [ | ||
| "slow: marks tests as slow (deselect with '-m \"not slow\"')", | ||
| ] | ||
| markers = ["slow: marks tests as slow (deselect with '-m \"not slow\"')"] |
There was a problem hiding this comment.
Not sure why this is all in red. Just a change in line-wrapping from my autoformatter.
There was a problem hiding this comment.
Not sure either but it's very scary.
zaneselvans
added
the
release
| git_describe_command = [ | ||
| "git", | ||
| "describe", | ||
| "--dirty", | ||
| "--tags", | ||
| "--long", | ||
| "--match", | ||
| "v20*", | ||
| ] |
There was a problem hiding this comment.
We can deal with the eventual failure in 77 years :)
| markers = [ | ||
| "slow: marks tests as slow (deselect with '-m \"not slow\"')", | ||
| ] | ||
| markers = ["slow: marks tests as slow (deselect with '-m \"not slow\"')"] |
There was a problem hiding this comment.
Not sure either but it's very scary.
Overview
Update configuration for
setuptools_scmsuch that it only considers tags matchingv20*when trying to determine the current version.Related to #3140
Testing
After altering
pyproject.tomlI attempted to install the PUDL package usingpipTo-do list